On Tue, Jun 26, 2012 at 06:05:41PM +0300, Zeeshan Ali (Khattak) wrote: > On Tue, Jun 26, 2012 at 12:16 PM, Christophe Fergeau > <cfergeau@xxxxxxxxxx> wrote: > > On Tue, Jun 26, 2012 at 05:56:13AM +0300, Zeeshan Ali (Khattak) wrote: > >> From: "Zeeshan Ali (Khattak)" <zeeshanak@xxxxxxxxx> > >> > >> - gvir_config_capabilities_cpu_add_feature > >> - gvir_config_capabilities_cpu_set_topology > >> --- > >> libvirt-gconfig/libvirt-gconfig-capabilities-cpu.c | 32 ++++++++++++++++++++ > >> libvirt-gconfig/libvirt-gconfig-capabilities-cpu.h | 6 ++++ > >> libvirt-gconfig/libvirt-gconfig.sym | 6 ++++ > >> 3 files changed, 44 insertions(+) > >> > >> diff --git a/libvirt-gconfig/libvirt-gconfig-capabilities-cpu.c b/libvirt-gconfig/libvirt-gconfig-capabilities-cpu.c > >> index df77364..e517a20 100644 > >> --- a/libvirt-gconfig/libvirt-gconfig-capabilities-cpu.c > >> +++ b/libvirt-gconfig/libvirt-gconfig-capabilities-cpu.c > >> @@ -56,6 +56,21 @@ gvir_config_capabilities_cpu_get_arch(GVirConfigCapabilitiesCpu *cpu) > >> return gvir_config_object_get_node_content(GVIR_CONFIG_OBJECT(cpu), "arch"); > >> } > >> > >> +/** > >> + * gvir_config_capabilities_cpu_add_feature: > >> + * > >> + * Adds a new feature to CPU. > > > > I don't know if it's worth mentioning in the doc that some of these objects > > can be read-only? I'm not sure how to say that in a non-confusing way > > though. > > Why are they read-only? You can change the XML in every way you like, > just that in case of capabilities itself, you cant do anything with > the modified XML but since we don't have any API for setting caps This is what I wanted to say ;) > its already obvious? Hmm true in this case, my comment would have been more appropriate on the topology setters then ;) Christophe
Attachment:
pgpgBaiAQAaCV.pgp
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list