Re: [PATCH v2 2/5] virsh: Expose virDomainGetInterfacesAddresses

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/21/12 15:55, Michal Privoznik wrote:
---
  tools/virsh.c   |   41 +++++++++++++++++++++++++++++++++++++++++
  tools/virsh.pod |    9 +++++++++
  2 files changed, 50 insertions(+), 0 deletions(-)

  /* "domifstat" command
   */
  static const vshCmdInfo info_domifstat[] = {
@@ -17841,6 +17881,7 @@ static const vshCmdDef domMonitoringCmds[] = {
      {"domblkstat", cmdDomblkstat, opts_domblkstat, info_domblkstat, 0},
      {"domcontrol", cmdDomControl, opts_domcontrol, info_domcontrol, 0},
      {"domif-getlink", cmdDomIfGetLink, opts_domif_getlink, info_domif_getlink, 0},
+    {"domifaddr", cmdDomIfAddr, opts_domifaddr, info_domifaddr, 0},
      {"domiflist", cmdDomiflist, opts_domiflist, info_domiflist, 0},
      {"domifstat", cmdDomIfstat, opts_domifstat, info_domifstat, 0},
      {"dominfo", cmdDominfo, opts_dominfo, info_dominfo, 0},

Pretty straightforward expousure of the API. I'd probably go for a name that contains XML to denote what we're returning. It's because I'd like to see a tabular output like other commands and maybe return the XML with flag for that command. ACK for correctness of this patch, but I'll look into doing the tabular output after reviewing the rest of the series.

Peter

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]