On 2012年06月25日 19:34, Daniel P. Berrange wrote:
On Mon, Jun 25, 2012 at 06:49:52PM +0800, Osier Yang wrote:
"cannot set memory of an active domain" is misleading, it sounds
like setting memory of active domain is not supported.
---
src/qemu/qemu_driver.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 5713650..bb33fd5 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -2037,7 +2037,8 @@ static int qemudDomainSetMemoryFlags(virDomainPtr dom, unsigned long newmem,
/* Lack of balloon support is a fatal error */
if (r == 0) {
qemuReportError(VIR_ERR_OPERATION_INVALID, "%s",
- _("cannot set memory of an active domain"));
+ _("Lacks of balloon support, perhaps"
+ " the balloon device is disabled"));
goto endjob;
This doesn't read quite right. Perhaps use
_("Unable to change memory of active domain without "
"the balloon device and guest OS balloon driver")
Yeah, more precicely, I pushed with it, assuming there is
an ACK from you. :-)
Osier
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list