I fixed a typo in the strace debug feature, if you specified
LIBVIRT_SANDBOX_STRACE=poll it would write "strace =poll" in the
kernel command line and consequently it wouldn't get picked up because
of that extra space.
Also, the example virt-sandbox.py was a bit outdated so I updated it.
The shell.py doesn't work as it has serial1 hardcoded for qemu. I
haven't checked the rest.
commit c9258ea3485a20c0b02f261fd9b8de4af32bf201
Author: Radu Caragea <sinaelgl@xxxxxxxxx>
Date: Tue Jun 19 12:18:02 2012 +0300
Fix python example and typo in strace kernel cmdline
diff --git a/examples/virt-sandbox.py b/examples/virt-sandbox.py
index 3c3223c..922ad00 100755
--- a/examples/virt-sandbox.py
+++ b/examples/virt-sandbox.py
@@ -23,7 +23,7 @@ conn.open(None)
ctxt = LibvirtSandbox.ContextInteractive.new(conn, cfg)
ctxt.start()
-con = ctxt.get_console()
+con = ctxt.get_app_console()
def closed(obj, error):
Gtk.main_quit()
diff --git a/libvirt-sandbox/libvirt-sandbox-builder-machine.c b/libvirt-sandbox/libvirt-sandbox-builder-machine.c
index 7fb6997..60f11b6 100644
--- a/libvirt-sandbox/libvirt-sandbox-builder-machine.c
+++ b/libvirt-sandbox/libvirt-sandbox-builder-machine.c
@@ -176,7 +176,7 @@ static gchar *gvir_sandbox_builder_machine_cmdline(GVirSandboxConfig *config G_G
if ((tmp = getenv("LIBVIRT_SANDBOX_STRACE"))) {
g_string_append(str, " strace");
if (!g_str_equal(tmp, "1")) {
- g_string_append(str, " =");
+ g_string_append(str, "=");
g_string_append(str, tmp);
}
}
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list