Re: [PATCHv2 variant 2] snapshot: implement new APIs for esx and vbox

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2012/6/12 Eric Blake <eblake@xxxxxxxxxx>:
> The two new APIs are rather trivial; based on bits and pieces of
> other existing APIs.  I chose to blindly return 0 for HasMetadata,
> since we already do that for other APIs like domainIsPersistent.
>
> * src/esx/esx_driver.c (esxDomainSnapshotIsCurrent)
> (esxDomainSnapshotHasMetadata): New functions.
> * src/vbox/vbox_tmpl.c (vboxDomainSnapshotIsCurrent)
> (vboxDomainSnapshotHasMetadata): Likewise.
> ---
>
> This version avoids existence checks.  I don't like it, but it is
> shorter, so it's worth posting.
>
>  src/esx/esx_driver.c |   50 ++++++++++++++++++++++++++++++++++
>  src/vbox/vbox_tmpl.c |   73 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 123 insertions(+)

ACK, to this one to as it is just a short version of variant 1, so you
got to choose :)

-- 
Matthias Bolte
http://photron.blogspot.com

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]