On 06/12/2012 06:42 PM, Eric Blake wrote: >> I really need to list this as a comment. I'll post a v2, adding >> comments and including your improvements. > > Here's what I'll squash for my v2: > > + /* First, determine if we can use the new child listing API. */ > + if (!ctl->useSnapshotOld && > + (count = virDomainSnapshotNumChildren(from, flags) < 0) && Ouch - nasty typo on my part in transcribing Peter's suggestions (hint - ')' in the wrong place). All the more reason for me to post a corrected v2. -- Eric Blake eblake@xxxxxxxxxx +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list