On Wed, Jun 13, 2012 at 01:29:27AM +0200, Jiri Denemark wrote: > When a libvirt API is called from the main event loop (which seems to be > common in event-based glib apps), the client IO loop would properly > handle keepalive requests sent by a server but will not actually send > them because the main event loop is blocked with the API. This patch > gets rid of response timer and the thread which is processing keepalive > requests is also responsible for queueing responses for delivery. > --- > src/rpc/virkeepalive.c | 155 +++++++++++------------------------------- > src/rpc/virkeepalive.h | 3 +- > src/rpc/virnetclient.c | 35 +++++++++- > src/rpc/virnetserverclient.c | 88 ++++++++++++------------ > 4 files changed, 120 insertions(+), 161 deletions(-) ACK. Again quite hard to follow the patch, so I reviewed the result of applying it instead. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list