Re: [PATCH] snapshot: avoid virsh crash with older servers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/10/2012 09:58 PM, Osier Yang wrote:
> On 2012年06月09日 01:56, Eric Blake wrote:
>> Commits 51082301, 16d7b39, and 521cc447 introduced support for
>> 'virsh snapshot-list --from' when talking to a server older than
>> 0.9.5, but broke support for plain 'virsh snapshot-list' for the
>> same old server in the process.  Because the code is not properly
>> gated, we end up with a SIGSEGV during a strcmp with a NULL argument.
>>
>> * tools/virsh.c (cmdSnapshotList): Don't waste time on fallbacks
>> when --from is not present.

> 
> ACK.

Thanks; pushed.

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]