On 06/04/2012 07:19 AM, Eric Blake wrote: > On 06/04/2012 04:29 AM, Michal Privoznik wrote: >> On 04.06.2012 05:37, Wen Congyang wrote: >>> --- >>> tools/virsh.c | 170 ++++++++++++++++++++++++++++---------------------------- >>> 1 files changed, 85 insertions(+), 85 deletions(-) >>> >> Therefore we need slightly different approach: >> >> https://www.redhat.com/archives/libvir-list/2012-June/msg00055.html >> >> Maybe others should step in and share their opinions. > > I actually prefer Wen's solution, and think it is better to be > consistent with # processing even if it looks odd in function context. > > ACK to Wen's version. And I've now pushed it, under the build-breaker rule. -- Eric Blake eblake@xxxxxxxxxx +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list