On 06/01/2012 11:28 AM, Marti Raudsepp wrote:
> Hi list,
>
> Currently, monitoring QEMU virtual machines with standard Unix
> sysadmin tools is harder than it has to be. The QEMU command line is
> often miles long and mostly redundant, it's hard to tell which process
> is which.
>
> This patch reorders the QEMU -name argument to be the first, so it's
> immediately visible in "ps x", htop and "atop -c" output.
These two paragraphs belong better as the commit message.
>
> Patch attached and also available from my github fork (master @
> git://github.com/intgr/libvirt.git)
>
> Regards,
> Marti
>
>
> 0001-qemu-Move-name-arg-to-be-the-1st-so-it-s-visible-in-.patch
>
>
> From 81fb7b9ed8decb67d83dd2e8a4e2eae579e96acd Mon Sep 17 00:00:00 2001
> From: Marti Raudsepp <marti@xxxxxxxxx>
> Date: Fri, 1 Jun 2012 19:25:33 +0300
> Subject: [PATCH] qemu: Move -name arg to be the 1st so it's visible in "ps x"
> output etc
This is a bit long; I trimmed it in length so that 'git shortlog -30'
doesn't wrap so badly:
qemu: move -name arg to be 1st in "ps x" output
>
> - cmd = virCommandNewArgList(emulator, "-S", NULL);
> + cmd = virCommandNewArgList(emulator, NULL);
Once you get down to no args, it's more efficient to do:
virCommandNew(emulator);
And one BIIIIG problem - making this change means that 'make check'
fails, unless you update ALL of the tests to match. But I agree with
the concept, so I was okay making the change (sed scripting to the
rescue, thankfully).
ACK with those modifications, so I will push once I complete the
testsuite conversion. I will also be adding you to AUTHORS; let me know
if you prefer a different spelling than what you used to make your commit.
--
Eric Blake eblake@xxxxxxxxxx +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list