On 06/01/2012 02:46 AM, Frido Roose wrote: > > I wondered why virDomainLockManagerAddDisk is called when detaching a disk > device. It even looks like this succeeds and then virLockManagerRelease is > called, which cleans up all sanlock resources for the domain. > > I suspect a function like virDomainLockManagerRemoveDisk(lock, disk) should > be called at this point that releases the specific disk, which does not yet > exist. Yes, that sounds reasonable. > Only virLockDriverAddResource exists in the _virLockDriver struct. > > I have the feeling that this sanlock is not completely implemented yet? Or > am I missing something big? You are correct that no one has coded it yet - since it seems to be your itch, would you mind taking a stab at writing the patch to add it? -- Eric Blake eblake@xxxxxxxxxx +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list