On 05/30/2012 07:08 AM, Eric Blake wrote: > On 05/30/2012 03:20 AM, Wen Congyang wrote: >> virCommandRunAsync() will set errfd if it successes. We should > > s/successes/succeeds/ > >> close it if virFDStreamOpenInternal() fails. >> >> --- >> src/fdstream.c | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/src/fdstream.c b/src/fdstream.c >> index d0ea0ee..f068439 100644 >> --- a/src/fdstream.c >> +++ b/src/fdstream.c >> @@ -673,6 +673,7 @@ error: >> VIR_FORCE_CLOSE(fds[0]); >> VIR_FORCE_CLOSE(fds[1]); >> VIR_FORCE_CLOSE(fd); >> + VIR_FORCE_CLOSE(errfd); > > ACK. I've pushed 1 and 3, and will post a v2 series with my patch and the split-up version of your patch 2 once I complete another round of testing. -- Eric Blake eblake@xxxxxxxxxx +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list