On Tue, 22 May 2012 10:18:22 +0100 Stefan Hajnoczi <stefanha@xxxxxxxxx> wrote: > QMP commands should be added to qapi-schema.json as described in > docs/writing-qmp-commands.txt. Looks like there's consensus on dropping this patch and enhancing getfd to return the fd number. This would require to first convert getfd from plain HMP to the QAPI, which is basically to say more or less the same thing as Stefan said above (you could also look for examples searching for "qapi: convert" in the git log). But there's a small problem. Today getfd commands are closely tied to the Monitor. In Anthony's development tree, the getfd commands are tied to the new QMP server's session support. Asking you to integrate the new QMP server only to have the getfd command returning a simple integer would be too much, but at the same time I think you'll have to at least to break it from the monitor. This means moving its data structure away from the Monitor object and probably reworking the internal API used to get fds (ie. monitor_get_fd()). Shouldn't be hard, but you should be careful not to break external users. -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list