Re: [PATCH][libvirt-glib] glib-events: Allow zero timeouts for timer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 22, 2012 at 05:37:25PM +0200, Michal Privoznik wrote:
> In libvirt, it's perfectly possible and widely used to have disabled
> timers (timeout=-1) and fire them up 'randomly' with timeout=0.
> However, with current mapping into glib mainloop it's not possible
> and causing troubles.

The code is more logical this way, when updating a timeout, we want to
remove the currently pending timeout callback, and reschedule a new one
with the updated value. Thanks a lot for tracking this down!
Looks good to me, but better if someone else ACKs it since I suggested this
change ;)

Christophe

Attachment: pgpH7c6cl7vf8.pgp
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]