Re: [PATCHv2] qemu_hotplug: Don't free the PCI device structure after hot-unplug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/22/2012 03:00 AM, Peter Krempa wrote:
> The pciDevice structure corresponding to the device being hot-unplugged
> was freed after it was "stolen" from activeList. The pointer was still
> used for eg-inactive list. This patch removes the free of the structure
> and frees it only if reset fails on the device.
> ---
> I've added a check for activePci to be non-null. This should not happen
> now that the activePciHostdevs list does not get corrupted, but if the lookup for
> some strange reason fails, don't enter pciResetDevice with NULL activePci that would
> cause a segfault.
> ---
> 
>  src/qemu/qemu_hotplug.c |   11 +++++++----
>  1 files changed, 7 insertions(+), 4 deletions(-)

ACK.

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]