Re: [PATCH 05/10] Replace RTLD_LOCAL with RTLD_GLOBAL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/21/2012 01:59 PM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
> 
> Since we have drivers which depend on each other (ie QEMU/LXC
> depend on the network driver APIs), we need to use RTLD_GLOBAL
> instead of RTLD_LOCAL. While this pollutes the calling binary
> with many more symbols, this is no worse than if we directly
> link to the drivers, and this only applies to libvirtd
> 
> * src/driver.c: s/RTLD_LOCAL/RTLD_GLOBAL/
> 
> Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx>
> ---
>  src/driver.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/driver.c b/src/driver.c
> index 5034277..fb162e0 100644
> --- a/src/driver.c
> +++ b/src/driver.c
> @@ -59,7 +59,7 @@ virDriverLoadModule(const char *name)
>          goto cleanup;
>      }
>  
> -    handle = dlopen(modfile, RTLD_NOW | RTLD_LOCAL);
> +    handle = dlopen(modfile, RTLD_NOW | RTLD_GLOBAL);

ACK.

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]