On Fri, May 11, 2012 at 10:05:52PM -0400, Stefan Berger wrote: > On 05/11/2012 12:48 PM, Daniel P. Berrange wrote: > >From: "Daniel P. Berrange"<berrange@xxxxxxxxxx> > > > >Normal practice is for cgroups controllers to be mounted at > >/sys/fs/cgroup. When setting up a container, /sys is mounted > >with a new sysfs instance, thus we must re-mount all the > >cgroups controllers. The complexity is that we must mount > >them in the same layout as the host OS. ie if 'cpu' and 'cpuacct' > >were mounted at the same location in the host we must preserve > >this in the container. Also if any controllers are co-located > >we must setup symlinks from the individual controller name to > >the co-located mount-point > > With this nit, I'd ACK the series. I applied the other previously ACK'd patches in this series, and have re-sent an update of just this last patch. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list