On 05/15/2012 11:19 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" <berrange@xxxxxxxxxx> > > The virDomainDeviceInfoIsSet API was only checking if an > address or alias was set in the struct. Thus if only a > rom bar setting / filename, boot index, or USB master > value was set, they could be accidentally dropped when > formatting XML > --- > src/conf/domain_conf.c | 15 +++++++++++---- > src/conf/domain_conf.h | 4 ++++ > 2 files changed, 15 insertions(+), 4 deletions(-) Oops. ACK. Good idea putting the cautionary note in the struct definition; hopefully that will prevent the same omission in the future. -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list