> >> Thanks, your patch looks good but needs two further small additions
> >> to the libvirt_sanlock.aug and test_libvirt_sanlock.aug files to
> >> take account of the new config parameter.
> >
> > Oops, Updated patch attached (tested with augparse)
> >
> > David
> >
> >
> > ----------------------------------------
> >
> > commit 33678a8b2d294bebf327106d586d41c9b157174f
> > Author: David Weber <wb@xxxxxxxxxxxx>
> > Date: Mon May 14 09:43:27 2012 +0200
> >
> > Add ignore param for readonly and shared disk in sanlock
>
> ACK and pushed, after fixing up whitespace nits ('make syntax-check'
> would have caught the trailing whitespace, but not the other one), and
> adding you to AUTHORS (let me know if you prefer an alternate spelling).
Thanks for the push. Sorry for all the problems. I'll do it better next
time ;)
>
> Is it sanlock, or libvirt, or a combination of both that don't yet
> support shared resource locks? I modified this as follows (and hope
> that it was good enough, since I pushed):
>
> # Enable this flag to have sanlock ignore readonly and shared disks.
> # If disabled, then this rejects attempts to share resources until
> # sanlock gains support for shared locks.
> #
> #ignore_readonly_and_shared_disks = 1
Right, it's sanlock who doesn't support it. So your text is right.
David
To: eblake@xxxxxxxxxx
Cc: berrange@xxxxxxxxxx
libvir-list@xxxxxxxxxx
sanlock-devel@xxxxxxxxxxxxxxxxxxxxxx
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list