On 05/14/2012 06:24 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" <berrange@xxxxxxxxxx> > > The uhci1, uhci2, uhci3 companion controllers for ehci1 must > have a master start port set. Since this value is predictable > we should set it automatically if the app does not supply it > --- > src/conf/domain_conf.c | 22 ++++++++++++++++++ > .../qemuxml2argv-usb-ich9-ehci-addr.xml | 24 +++++--------------- > 2 files changed, 28 insertions(+), 18 deletions(-) ACK. But shouldn't we also have a test in qemuxml2xmltest, by using a file in qemuxml2xmloutdata/, that shows that we generate the correct start port on output in response to a user omitting information that we can determine by default? -- Eric Blake eblake@xxxxxxxxxx +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list