On Wed, May 09, 2012 at 11:44:24PM +0300, Zeeshan Ali (Khattak) wrote:
> On Wed, May 9, 2012 at 5:54 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote:
> > On Wed, May 09, 2012 at 04:16:15AM +0300, Zeeshan Ali (Khattak) wrote:
> >> From: "Zeeshan Ali (Khattak)" <zeeshanak@xxxxxxxxx>
> >>
> >> Not quite complete but its a good start.
> >> +{
> >> + g_debug("Init GVirConfigCapabilitiesGuest=%p", conn);
> >> +
> >> + conn->priv = GVIR_CONFIG_CAPABILITIES_GUEST_GET_PRIVATE(conn);
> >> +}
> >> +
> >> +GVirConfigDomainOsType
> >
> > I don't think this is the right return type, this enum currently translates to "hvm",
> > "linux" and "exe", while "xen" and "uml" should also be valid (re-reading
> > libvirt source code, it might have been better to use a string instead of
> > this enum).
> > The only valid values for guest caps os type are "xen" and "hvm"
>
> RTF RNG :)
Sorry slightly out of date documentation in src/conf/capabilities.c, I've
confirmed that all these values are used with:
git grep -A 1 virCapabilitiesAddGuest\(
GVIR_CONFIG_DOMAIN_OS_TYPE_UML and GVIR_CONFIG_DOMAIN_OS_TYPE_XEN need to
be added to GVirConfigDomainOsType.
Christophe
Attachment:
pgp_SiMW25HPh.pgp
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list