On 04/20/2012 07:13 AM, Marc-André Lureau wrote: > The code uses long long for pid_t now. > It fails on mingw64 without this change. > --- > src/util/virpidfile.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/util/virpidfile.c b/src/util/virpidfile.c > index 59d0c94..27811e1 100644 > --- a/src/util/virpidfile.c > +++ b/src/util/virpidfile.c > @@ -316,8 +316,7 @@ cleanup: > return rc; > } > > - > -verify(sizeof(pid_t) <= sizeof(unsigned int)); > +verify(sizeof(pid_t) <= sizeof(long long)); All integers are smaller than 'long long' (well, I know that there is work to add 128-bit integers, but you'd be crazy to make pid_t that big). I'd rather just delete the assertion altogether. ACK with that change, and pushed. -- Eric Blake eblake@xxxxxxxxxx +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list