On Wed, May 2, 2012 at 1:34 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: > What happens when some parameters are not listed/when some blank lines are > missing? > > Does it output a warning, or abort? You get a warning. >> diff --git a/libvirt-gconfig/libvirt-gconfig-domain.c b/libvirt-gconfig/libvirt-gconfig-domain.c >> index 33a69e3..c8cd1c5 100644 >> --- a/libvirt-gconfig/libvirt-gconfig-domain.c >> +++ b/libvirt-gconfig/libvirt-gconfig-domain.c >> @@ -277,6 +277,7 @@ static gboolean add_feature(xmlNodePtr node, gpointer opaque) >> @@ -337,6 +337,7 @@ gboolean gvir_domain_start(GVirDomain *dom, >> /** >> * gvir_domain_resume: >> * @dom: the domain >> + * @err: Place-holder for possible errors > > I'm a bit surprised that here you add a @err annotation, but further down > the patch you rename some @err to @error. Was the renaming an unrelated > cleanup, or was gir complaining about it? Now that you ask, I don't recall any more. I should have sent this patch when i wrote it so then I would have remembered. :( I'll check again by removing those changes.. -- Regards, Zeeshan Ali (Khattak) FSF member#5124 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list