Re: [PATCH] Ensure libvirt_lxc process loads the live XML config

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/30/2012 08:52 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
> 
> Currently the libvirt_lxc process uses VIR_DOMAIN_XML_INACTIVE
> when loading the XML for the container. This means it looses

s/looses/loses/

> any dynamic data such as the, just allocated, SELinux label.
> 
> Further there is an inconsistency in the libvirt LXC driver
> whereby it saves the live config XML and then later overwrites
> the file with the live status XML instead. Add a comment about
> this for future reference.
> 
> * src/lxc/lxc_controller.c: Remove VIR_DOMAIN_XML_INACTIVE
>   when loading XML
> * src/lxc/lxc_driver.c: Add comment about inconsistent
>   config file formats
> 
> Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx>
> ---
>  src/lxc/lxc_controller.c |    2 +-
>  src/lxc/lxc_driver.c     |   14 ++++++--------
>  2 files changed, 7 insertions(+), 9 deletions(-)

ACK.

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]