Re: [PATCH] cpu: Improve error reporting on incompatible CPUs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/19/2012 07:45 AM, Jiri Denemark wrote:

>> +#define virX86CpuIncompatible(MSG, CPU_DEF)                             \
>> +        do {                                                            \

>> +        } while (0);
> 
> I can't think of any case where ";;" would be a problem but I'd remove the ';'
> from the end of this macro anyway

I can:

if (cond)
    virX86CpuIncompatible(msg, def);
else
    do_something_else();

that bogus ';' in the #define means you now have a syntax error.

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]