Re: [PATCH] Fix a memory leak

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/17/2012 03:03 PM, Eric Blake wrote:
On 04/17/2012 12:55 PM, Stefan Berger wrote:

      }

+    dest->type = src->type;
+
ACK.  No good writing into a union if you forget to also update the
discriminator to say which branch of the union is active.  The missing
assignment definitely explains the memory leak.

Pushed.

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]