On 04/12/2012 01:14 PM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
>
> The policy kit and HAL node device drivers both require a
> DBus connection. The HAL device code further requires that
> the DBus connection is integrated with the event loop and
> provides such glue logic itself.
>
> The forthcoming FirewallD integration also requires a
> dbus connection with event loop integration. Thus we need
> to pull the current event loop glue out of the HAL driver.
>
> Thus we create src/util/virdbus.{c,h} files. This contains
> just one method virDBusGetSystemBus() which obtains a handle
> to the single shared system bus instance, with event glue
> automagically setup.
>
> NB, I have not actually tested this on a system with HAL or
> PolicyKit-0 installed, so it may well not compile. Hopefully
> someone on list has a suitable system where they can test
> those two. If not, I'll install a VM next week to test it in.
>
> ---
> .gitignore | 6 ++--
> configure.ac | 3 +-
> daemon/Makefile.am | 3 +-
> daemon/libvirtd.c | 4 ---
> src/Makefile.am | 3 +-
> src/rpc/virnetserver.c | 6 ----
> src/rpc/virnetserver.h | 4 ---
> src/util/virdbus.c | 68 ++++++++++++++++++++++-------------------------
> 8 files changed, 40 insertions(+), 57 deletions(-)
Did you forget to squash this into a prior patch? The commit message
mentions a new file virdbus.h that I don't see here, and since I don't
have virdbus.c, this patch won't apply.
--
Eric Blake eblake@xxxxxxxxxx +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list