On 03/29/2012 03:10 PM, Laine Stump wrote: > 2) if it's set, the option ",name=com.redhat.spice.0" is added to the > device string. > > So it looks like you could get the same effect by changing that last bit > to either add the contents of dev->target.name, or if that's NULL, > "com.redhat.spice.0". I'd be fine with a patch along these lines that moves the default out of domain_conf.c and into the command line generator. > Does anyone with more experience with the libvirt spice code have any > opinion on whether it makes any difference if we add in the default in > the parsing function or just when we build the commandline? danpb? Delaying the default until command line generation should be just fine. -- Eric Blake eblake@xxxxxxxxxx +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list