Re: [PATCH 2/4] Fix format specifiers in test cases on Win32

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/29/2012 05:53 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
>
> Some of the test suites use fprintf with format specifiers
> that are not supported on Win32 and are not fixed by gnulib.
>
> The mingw32 compiler also has trouble detecting ssize_t
> correctly, complaining that 'ssize_t' does not match
> 'signed size_t' (which it expects for %zd). Force the
> cast to size_t to avoid this problem
>
> * tests/testutils.c, tests/testutils.h: Fix printf
>   annotation on virTestResult. Use virVasprintf
>   instead of vfprintf
> * tests/virhashtest.c: Use VIR_WARN instead of fprintf(stderr).
>   Cast to size_t to avoid mingw32 compiler bug
>
> Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx>
> ---
>  tests/testutils.c   |    8 ++++++--
>  tests/testutils.h   |    3 ++-
>  tests/virhashtest.c |   24 +++++++++++++++---------
>  3 files changed, 23 insertions(+), 12 deletions(-)

ACK

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]