Re: [PATCHv2] virsh: plug memory leaks on failure path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/28/2012 02:43 AM, Alex Jia wrote:
> Leaks are introduced in commit 1cf0e3d and fe383bb.
> 
> Fixing memory leaks, in addition, the patch also fixs a potential missing 

s/fixs/fixes/

> return value issue in 'if (from)' statement, without the fixing, although 
> the programming met a error, the subsequent codes will be executed 
> continually.  
> 

> 
> 
> Signed-off-by: Alex Jia <ajia@xxxxxxxxxx>
> ---
>  tools/virsh.c |    9 +++++----
>  1 files changed, 5 insertions(+), 4 deletions(-)

ACK.

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]