On 03/26/2012 03:48 AM, Martin Kletzander wrote: > On 03/26/2012 05:43 AM, Osier Yang wrote: >> On 2012年03月23日 15:34, Martin Kletzander wrote: >>> After cleanup introduced with previous commit, there is a need for >>> syntax-check rule taking care of return(). Regexp used in 'prohibit' >>> parameter is taken from the cleanup commit and modified so it fits >>> 'grep -E' format. Semicolon at the end is needed, otherwise the regexp >>> could match return with cast. >>> >> >> Looks good from my point of view, ACK. But we might need to >> push these later after 0.9.11. I see no problem with going for it now, as it is supposed to be no semantic change; and the longer we wait, the more likely it is to have conflicts when we rebase it later. > We've totally missed the '^' in the exception, that shouldn't be there, > so either please fix this before pushing it or send me NACK or ping me > on IRC so I know if I should send fixed version, thanks and sorry for > the trouble. I fixed that up, and pushed the series. -- Eric Blake eblake@xxxxxxxxxx +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list