On Tue, Mar 13, 2012 at 04:15:59PM +0100, Christophe Fergeau wrote: > Hey, > > On Tue, Mar 13, 2012 at 01:22:09AM +0100, Marc-André Lureau wrote: > > On Mon, Mar 12, 2012 at 5:56 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: > > > Ping for this patch and for 3/3 ? > > > > ./test-domain-create gives: > > > > <channel type="spicevmc"> > > <target type="channel-target-virtio"/> > > </channel> > > > > Where we expect this: > > > > <channel type='spicevmc'> > > <target type='virtio' name='com.redhat.spice.0'/> > > <address type='virtio-serial' controller='0' bus='0' port='1'/> > > </channel> > > The "address" element is optional, see > http://libvirt.org/formatdomain.html#elementCharChannel "The optional > address element can tie the channel to a particular type='virtio-serial' > controller." > It seems libvirt will still do the right thing if it's omitted: > http://libvirt.org/formatdomain.html#elementsAddress > I tend to only add API in libvirt-gconfig when there's a need for it, but I > can look into adding API to set the address element if you think that's > needed now. Yes, there is no need to specify an <address> element really. Just let libvirt do its thing. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list