On Friday 03 February 2012 09:42:29 Matthias Bolte wrote: > You changed all lifecycle functions not to rely on possible stale > information, but you missed to update the cached state information in > the virDomainObj list resulting in virsh list giving wrong output and > possibly listing VMs as active that aren't active anymore. > > Maybe you should replace vmwareGetVMStatus with vmwareUpdateVMStatus > that updates the cached information in a virDomainObj and call it in > all places that read information from a virDomainObj. > > A more general question: is this driver supposed to work properly when > someone uses vmrun to alter a VMs behind libvirt's back? If that's the > case then maybe this driver should not cache anything at all and work > like the vSphere, Hyper-V or VirtualBox driver. They always query the > hypervisor for information and cache nothing. > > I'm not sure what's the best approach here. Hi, The problem here is that contrary to vSphere, Hyper-V or VirtualBox, I have no way to get a list of defined domains as vmrun only lists running domains. So I think I'll do as you suggested and go for a vmwareUpdateVMStatus function. Regards, Jean-Baptiste -- Jean-Baptiste ROUAULT Ingénieur R&D - diateam : Architectes de l'information Phone : +33 (0)9 53 16 02 70 Fax : +33 (0)2 98 050 051 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list