On Mon, Mar 12, 2012 at 17:32:45 -0600, Eric Blake wrote: > On 03/12/2012 08:31 AM, Jiri Denemark wrote: > > When host-model and host-passthrouh CPU modes were introduced, qemu > > driver was properly modify to update guest CPU definition during > > migration so that we use the right CPU at the destination. However, > > similar treatment is needed for (managed)save and snapshots since they > > need to save the exact CPU so that a domain can be properly restored. > > To avoid repetition of such situation, all places that need live XML > > share the code which generates it. > > > > As a side effect, this patch fixes error reporting from > > qemuDomainSnapshotWriteMetadata(). > > --- > > src/conf/domain_conf.c | 3 ++- > > src/qemu/qemu_domain.c | 23 +++++++++++++++++++---- > > src/qemu/qemu_domain.h | 4 ++++ > > src/qemu/qemu_driver.c | 9 +++------ > > src/qemu/qemu_migration.c | 8 ++------ > > 5 files changed, 30 insertions(+), 17 deletions(-) > > I haven't tested this as much as I'd like, but by inspection, it looks > right, and I'd rather get it in now so we maximize our testing time. I tested managedsave and basic snapshot of a running domain and all was working fine. However, snapshots are so complicated I didn't even try to test all possibilities there. > ACK. Thanks and pushed. Jirka -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list