On 03/12/2012 08:07 AM, Paolo Bonzini wrote: > Il 12/03/2012 14:58, Eric Blake ha scritto: >>>> If not, perhaps a >>>>>> different state should be added so that "virsh resume" can look at the >>>>>> state and issue the appropriate monitor command (or alternatively, it >>>>>> could be considered a QEMU bug). >>>> >>>> We have the paused reason. And the patch which should be >>>> squashed in in the attachment. >>>> >>>> But I'm interested in trying if "virsh resume" wakeup a >>>> domain pasued by SUSPEND event. >> It won't. To wake up a guest in S3 suspension, you need the pmwakeup >> command, or else a timer or input device wakeup trigger. 'virsh resume' >> only wakes up a paused guest, not a power-management suspended guest. > > Also considering the autowakeup, I think PAUSED is the wrong state for a > pm-suspended domain. It should just stay RUNNING. Either it stays RUNNING (because we add no new states), or we add a new state (perhaps PMSUSPEND), and leave the new state when we receive the event telling us that an autowakeup occurred. -- Eric Blake eblake@xxxxxxxxxx +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list