Re: [PATCH] util: consolidate duplicated error messages in pci.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/08/2012 04:57 PM, Eric Blake wrote:
> On 03/08/2012 02:53 PM, Laine Stump wrote:
>> This is nearly identical to an earlier patch for virnetlink.c (after
>> fixing it per Eric's recommendations).
>>
>> There are special stub versions of all public functions in this file
>> that are compiled when the platform isn't linux. Each of these
>> functions had an almost identical message, differing only in the
>> function name included in the message. Since log messages already
>> contain the function name, we can just define a const char* with the
>> common part of the string, and use that same string for all the log
>> messages.
>>
>> If nothing else, this at least makes for less strings that need
>> translating...
>> ---
>>  src/util/pci.c |   23 +++++++++--------------
>>  1 files changed, 9 insertions(+), 14 deletions(-)
> ACK.
>
Pushed.

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]