Re: [PATCH 01/17] conf: add missing device types to virDomainDevice(Type|Def)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/28/2012 01:14 PM, Laine Stump wrote:
> Not all device types were represented in virDomainDeviceType, so some
> types of devices couldn't be represented in a virDomainDeviceDef
> (which requires a different type of pointer in the union for each
> different kind of device).
> 
> Since serial, parallel, channel, and console devices are all
> virDomainChrDef, and the virDomainDeviceType is never used to produce
> a string from the type (and only used in the other direction
> internally to code, never to produce XML), I only added one "CHR"
> type, which is associated with "virDomainChrDefPtr chr" in the union.
> ---
> New patch in V2.
> 
>  src/conf/domain_conf.c |    6 +++++-
>  src/conf/domain_conf.h |   11 +++++++++--
>  2 files changed, 14 insertions(+), 3 deletions(-)

ACK.

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]