On 03/02/2012 06:00 AM, Peter Krempa wrote: > On 02/11/2012 12:55 AM, Eric Blake wrote: >> Nuke the last vestiges of printing pid_t values with the wrong >> types, at least in code compiled on mingw64. There may be other >> places, but for now they are only compiled on systems where the >> existing %d doesn't trigger gcc warnings. >> >> * src/rpc/virnetsocket.c (virNetSocketNew): Use %lld and casting, >> rather than assuming any particular int type for pid_t. >> * src/util/command.c (virCommandRunAsync, virPidWait) >> (virPidAbort): Likewise. >> (verify): Drop a now stale assertion. >> --- >> diff --git a/src/util/command.c b/src/util/command.c >> index a2d5f84..b752b2a 100644 >> --- a/src/util/command.c >> +++ b/src/util/command.c >> @@ -50,9 +49,6 @@ >> virReportErrorHelper(VIR_FROM_NONE, code, >> __FILE__, \ >> __FUNCTION__, __LINE__, __VA_ARGS__) >> >> -/* We have quite a bit of changes to make if this doesn't hold. */ >> -verify(sizeof(pid_t)<= sizeof(int)); >> -2011-07-12 10:42:41 -0600 > > Didn't hold that long actually :) (It was added 2011-07-12 10:42:41 -0600 ) > > > ACK, Thanks; series pushed with 1/2 tweaked as mentioned. -- Eric Blake eblake@xxxxxxxxxx +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list