On Fri, Mar 2, 2012 at 5:58 PM, Daniel P. Berrange <berrange@xxxxxxxxxx> wrote: > On Fri, Mar 02, 2012 at 09:06:20AM +0800, Zhou Peng wrote: >> On Thu, Mar 1, 2012 at 5:32 PM, Daniel P. Berrange <berrange@xxxxxxxxxx> wrote: >> > On Thu, Mar 01, 2012 at 11:54:30AM +0800, Zhou Peng wrote: >> >> Signed-off-by: Zhou Peng <zhoupeng@xxxxxxxxxxxxxxx> >> >> >> >> spice agent-mouse support >> >> >> >> diff --git a/tests/qemuxml2argvdata/qemuxml2argv-channel-spicevmc.xml b/tests/qemuxml2argvdata/qemuxml2argv-channel-spicevmc.xml >> >> index 6505b55..266a4ed 100644 >> >> --- a/tests/qemuxml2argvdata/qemuxml2argv-channel-spicevmc.xml >> >> +++ b/tests/qemuxml2argvdata/qemuxml2argv-channel-spicevmc.xml >> >> @@ -23,7 +23,7 @@ >> >> <controller type='virtio-serial' index='1'> >> >> <address type='pci' domain='0x0000' bus='0x00' slot='0x0a' function='0x0'/> >> >> </controller> >> >> - <graphics type='spice' port='5903' tlsPort='5904' autoport='no' listen='127.0.0.1'> >> >> + <graphics type='spice' port='5903' tlsPort='5904' autoport='no' listen='127.0.0.1' agentmouse='off'> >> >> <channel name='main' mode='secure'/> >> >> </graphics> >> >> <channel type='spicevmc'> >> > >> > Rather than adding an attribute 'agentmouse' I think it'd be preferrable >> > to use a sub-element: >> > >> > <agent mouse='on|off'/> >> > >> > that way if we have more configuration related to the agent we have >> > a nice place to put it >> I take note of the implemented clipboard sub-element.. >> spice clipboard use agent too to implement copypaste like agentmouse. >> I realize your idea to separate is great in the long run and agree with >> you to use another sub-emement to describe, >> But I'm sorry I still don't agree with you to use >> <agent mouse='on|off'/> >> >> How about this way pls: >> <graphics type='spice' > >> <mouse mode='client|server'> > > Yes this looks fine to me. > OK, I will resend a new version patch after this weekend. Thanks Daniel. -- Zhou Peng -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list