On 03/01/2012 11:53 AM, Daniel P. Berrange wrote: > On Thu, Mar 01, 2012 at 11:43:04AM -0500, Laine Stump wrote: >> Commit 7c90026 added #include "conf/domain_conf.h" to >> util/virrandom.c. Fortunately it didn't actually use anything from >> domain_conf.h, since as far as I'm aware, files in util aren't allowed >> to reference anything in conf (although the opposite is allowed). So >> this #include is unnecessary. > That is correct. util/ must be self-contained > >> I verified it still compiles with the line removed, but have placed a >> one day moratorium on me doing any "trivial rule" pushes, so will >> wait for someone else to verify/ACK before pushing. >> --- >> src/util/virrandom.c | 1 - >> 1 files changed, 0 insertions(+), 1 deletions(-) >> >> diff --git a/src/util/virrandom.c b/src/util/virrandom.c >> index 151cf4b..9092fd2 100644 >> --- a/src/util/virrandom.c >> +++ b/src/util/virrandom.c >> @@ -29,7 +29,6 @@ >> #include "count-one-bits.h" >> #include "util.h" >> #include "virterror_internal.h" >> -#include "conf/domain_conf.h" >> >> #define VIR_FROM_THIS VIR_FROM_NONE > ACK, this is definitely a bogus include Thanks, pushed. > > Daniel -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list