On 03/01/2012 09:53 AM, Daniel P. Berrange wrote: > On Thu, Mar 01, 2012 at 11:43:04AM -0500, Laine Stump wrote: >> Commit 7c90026 added #include "conf/domain_conf.h" to >> util/virrandom.c. Fortunately it didn't actually use anything from >> domain_conf.h, since as far as I'm aware, files in util aren't allowed >> to reference anything in conf (although the opposite is allowed). So >> this #include is unnecessary. > > That is correct. util/ must be self-contained Guess what - that sounds like a great syntax rule to write, so we don't slip up in the future. Give me a few minutes, to see what I can come up with. Any other directories that should be avoiding particular includes? -- Eric Blake eblake@xxxxxxxxxx +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list