On Wed, Feb 29, 2012 at 02:18:31PM +0100, Christophe Fergeau wrote:
> On Tue, Feb 28, 2012 at 08:25:06PM +0200, Zeeshan Ali (Khattak) wrote:
> > From: "Zeeshan Ali (Khattak)" <zeeshanak@xxxxxxxxx>
> >
> > Remove now redundant 'path' property from GVirDomainDevice subclasses.
> > ---
> > libvirt-gobject/libvirt-gobject-domain-disk.c | 88 ++++----------------
> > libvirt-gobject/libvirt-gobject-domain-disk.h | 3 +-
> > libvirt-gobject/libvirt-gobject-domain-interface.c | 89 +++-----------------
> > libvirt-gobject/libvirt-gobject-domain-interface.h | 3 +-
> > 4 files changed, 31 insertions(+), 152 deletions(-)
> >
> > diff --git a/libvirt-gobject/libvirt-gobject-domain-disk.c b/libvirt-gobject/libvirt-gobject-domain-disk.c
> > index fb7672e..42e0e6c 100644
> > --- a/libvirt-gobject/libvirt-gobject-domain-disk.c
> > +++ b/libvirt-gobject/libvirt-gobject-domain-disk.c
> > @@ -34,75 +34,22 @@
> > #define GVIR_DOMAIN_DISK_GET_PRIVATE(obj) \
> > (G_TYPE_INSTANCE_GET_PRIVATE((obj), GVIR_TYPE_DOMAIN_DISK, GVirDomainDiskPrivate))
> >
> > -struct _GVirDomainDiskPrivate
> > -{
> > - gchar *path;
> > -};
>
> The rest of the code (GVirConfig*) always has a Private structure with a
> gboolean unused when it's empty, I'd rather we stayed consistent (though I
> keep thinking that we should remove these empty private structs everywhere
> :)
[snip]
> > diff --git a/libvirt-gobject/libvirt-gobject-domain-interface.h b/libvirt-gobject/libvirt-gobject-domain-interface.h
> > index 62848db..26b7d1c 100644
> > --- a/libvirt-gobject/libvirt-gobject-domain-interface.h
> > +++ b/libvirt-gobject/libvirt-gobject-domain-interface.h
> > @@ -59,7 +59,8 @@ struct _GVirDomainInterface
> > {
> > GVirDomainDevice parent;
> >
> > - GVirDomainInterfacePrivate *priv;
> > + /* In case we need a private struct in future */
> > + gpointer padding[1];
I prefer that we keep the empty private struct (with a dummy gboolean unsed),
rather than doing this.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list