Re: [libvirt-glib 4/6] Add 'config' property to GVirDomainDevice

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The code to add the property looks good to me except for one minor nit, see
below.
I'd rather to see patch 6/6 come right after it since I was wondering how
config was getting set.

On Tue, Feb 28, 2012 at 08:25:05PM +0200, Zeeshan Ali (Khattak) wrote:
> @@ -144,3 +166,13 @@ virDomainPtr gvir_domain_device_get_domain_handle(GVirDomainDevice *self)
>  GVirDomain *gvir_domain_device_get_domain(GVirDomainDevice *device) {
>      return g_object_ref (device->priv->domain);
>  }
> +
> +/**
> + * gvir_domain_device_get_config:
> + * @device: the domain device
> + *
> + * Returns: (transfer full): the config
> + */
> +GVirConfigDomainDevice *gvir_domain_device_get_config(GVirDomainDevice *device) {

{ on a new line

Christophe

Attachment: pgprXacwHtHTX.pgp
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]