Re: [PATCH 7/7] tests: Add tests for virtio-scsi and ibmvscsi controllers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/27/2012 04:59 AM, Osier Yang wrote:
> ---
>  .../qemuxml2argv-disk-scsi-virtio-scsi.args        |    9 +++++
>  .../qemuxml2argv-disk-scsi-virtio-scsi.xml         |   32 ++++++++++++++++++++
>  .../qemuxml2argv-disk-scsi-vscsi.args              |    8 +++++
>  .../qemuxml2argv-disk-scsi-vscsi.xml               |   32 ++++++++++++++++++++
>  tests/qemuxml2argvtest.c                           |    4 ++
>  tests/qemuxml2xmltest.c                            |    4 ++-
>  6 files changed, 88 insertions(+), 1 deletions(-)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-scsi-virtio-scsi.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-scsi-virtio-scsi.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-scsi-vscsi.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-scsi-vscsi.xml

OK, I think this fixes most of my comment on 4/7; but I still don't see
any non-zero target='1' entries in the new tests.

If you fix Paolo's nits, as well as enhance that aspect of the tests,
then you have my:

ACK series.

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]