On 02/06/2012 06:50 AM, Peter Krempa wrote: > This patch adds support for the newly introduced > VIR_DOMAIN_CONSOLE_FORCE and VIR_DOMAIN_CONSOLE_SAFE flags. The console > command now has an optional parameter --force that specifies that the > user wants to forcibly interrupt an ongoing console session and create > a new one. Flag --safe requests that the console should be opened only > if the hypervisor driver supports safe console handling. > > The behaviour to this point was that the daemon opened two streams to > the console, that competed for data from the pipe, and the result was > that both of the consoles ended up scrambled. > > This patch doesn't modify operation of other commands dealing with > console connections (start, create) as those open connections to newly > started domains making it virtualy impossible for another client to race s/virtualy/virtually/ ACK. And sorry for dragging this review on for so long - I promise to finish it today ;) -- Eric Blake eblake@xxxxxxxxxx +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list