On 02/21/2012 03:00 AM, Gerd Hoffmann wrote:
> [ added libvirt to Cc:, leaving full context.
> this is about qmp events when the guest enters/leaves s3 ].
>
>>> @@ -1436,12 +1437,26 @@ void qemu_register_suspend_notifier(Notifier *notifier)
>>>
>>> void qemu_system_wakeup_request(WakeupReason reason)
>>> {
>>> + static const char *names[] = {
>>> + [QEMU_WAKEUP_REASON_OTHER] = "other",
>>> + [QEMU_WAKEUP_REASON_RTC] = "rtc",
>>> + [QEMU_WAKEUP_REASON_PMTIMER] = "pmtimer",
>>
>> Is the reason really important for mngt? Can we just leave it out?
>
> I assumed the wakeup reason could be useful, but dunno.
> Zapping the code is no problem of course.
>
> Lets ask mgmt aka libvirt folks ;)
If you present the reason, libvirt will pass it on to the management
app. But I don't see any reason why libvirt itself would care about the
reason, so it won't hurt libvirt if you drop a reason field. I don't
know whether higher-level management apps, like oVirt, would care or not.
Isn't this something where it is easier to omit first and add later once
we have a use case, than to add up front only to find that no one cares?
--
Eric Blake eblake@xxxxxxxxxx +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list