On Mon, Feb 20, 2012 at 09:59:23AM +0100, Jiri Denemark wrote:
> On Mon, Feb 20, 2012 at 11:26:50 +0800, Daniel Veillard wrote:
> > diff --git a/src/util/virfile.h b/src/util/virfile.h
> > index ec1e90b..184677c 100644
> > --- a/src/util/virfile.h
> > +++ b/src/util/virfile.h
> > @@ -58,10 +58,10 @@ typedef virFileWrapperFd *virFileWrapperFdPtr;
> >
> > int virFileDirectFdFlag(void);
> >
> > -enum {
> > +enum virFileWrapperFdFlags {
> > VIR_FILE_WRAPPER_BYPASS_CACHE = (1 << 0),
> > VIR_FILE_WRAPPER_NON_BLOCKING = (1 << 1),
> > -} virFileWrapperFdFlags;
> > +};
>
> Actually the error was missing typedef (again, shame on me) but this patch
> fixes it as well and since we use these flags OR-ed, it's unlikely we will
> ever need to use the type anywhere.
Well let's make the typedef explicit, that's cleaner, ACK in advance
if you want to make that patch :-)
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list