On 02/17/2012 05:54 PM, Osier Yang wrote: >> Yeah, I definitely misunderstood. Here it is correct to print the >> target for all models. > > Do you mean it's correct check the model here? I think the "lsilogic" > model won't want to see the "target". It's complete useless. It's true that it's useless. However, there is no reason not to print it; so is "bus", for example. Also, even for non-SCSI disks you need to print the target. You may omit it if it is zero, but I'm not sure it brings any benefit to do so. By the way, you need to test for "target == 0" and print an error also when creating an IDE or AHCI disk. Paolo -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list