Re: [PATCH] snapshot: fix snapshot deletion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/15/2012 02:41 AM, Michal Privoznik wrote:
> On 14.02.2012 21:48, Eric Blake wrote:
>> Bug introduced in commit 35abced.  On an inactive domain,
>> $ virsh snapshot-create-as dom snap
>> $ virsh snapshot-create dom
>> $ virsh snapshot-create dom
>> $ virsh snapshot-delete --children dom snap
>> could crash libvirtd, due to a use-after-free that results
>> when the callback freed the current element in the iteration.
>>
>> * src/conf/domain_conf.c (virDomainSnapshotForEachChild)
>> (virDomainSnapshotActOnDescendant): Allow iteration to delete
>> current child.
>> ---
>>  src/conf/domain_conf.c |    5 +++--
>>  1 files changed, 3 insertions(+), 2 deletions(-)
>>
> 
> ACK

Thanks; pushed.

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]