Re: [PATCHv3] python: Fix problems of virDomain{Set, Get}BlkioParameters bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/10/2012 05:10 PM, Eric Blake wrote:
> On 02/10/2012 02:41 AM, ajia@xxxxxxxxxx wrote:
>> From: Alex Jia <ajia@xxxxxxxxxx>
>>
>> The parameter 'device_weight' is a string, however, the 'VIR_TYPED_PARAM_STRING'
>> type condition is missed by libvirt_virDomain{Set, Get}BlkioParameters bindings,
>> the result is we can't get or change 'device_weight' value.
>>

>> +    int nparams = 0, size = 0;
> 
> size should be Py_ssize_t.
> 
> ACK with that change.

Actually, it looks like Guannan's patch covers yours.

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]